feat: provide group-level view#18
Open
perfectra1n wants to merge 4 commits intoHandfish:mainfrom
Open
Conversation
2f3a729 to
56f186e
Compare
Owner
|
I'm going to spend a little bit of time revising the network screen and make sure the RX / TX, network capture, conns sub-screen all work on a group view. I may play also around with the UI a bit - otherwise this is a great PR in progress |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables hotkeys (
L,p,n,s,d) to work on group headers (Control Plane,Workers) in the TUI, showing aggregated views for all nodes in that group. Users can toggle between Interleaved (all nodes merged by timestamp) and ByNode (tabbed per-node) display modes.Group Hotkeys
When highlighting a
Control PlaneorWorkersgroup header, the following hotkeys now work:LpnsdView Modes
hostname:prefix to identify sourceNew Keybindings (Group Views)
v[]Changes to "core" functionality:
action.rs- Added 5 new action variants (ShowGroupLogs,ShowGroupProcesses,ShowGroupNetwork,ShowGroupStorage,ShowGroupDiagnostics)cluster.rs- Addedcurrent_group_nodes()andcommon_services_for_group()helpers; updated hotkey handlers to detect group selectionapp.rs- Added handlers for all group actions with proper client setup for refreshComponents that were added:
multi_logs.rs- AddedGroupViewMode, multi-node streaming, view toggle, tab navigationprocesses.rs- Added group view support withnew_group(),refresh_group(), view togglenetwork.rs- Added group view support withnew_group(),refresh_group(), view togglestorage.rs- Added group view support withnew_group(),refresh_group(), view togglediagnostics/mod.rs- Added group view support withnew_group(),refresh_group(), view toggleArchitecture
View Mode Toggle Flow
Also added some Unit Tests:
cluster.rscurrent_group_nodes(),common_services_for_group()network.rsget_display_devices()storage.rsget_display_disks(),get_display_volumes()diagnostics/mod.rsget_display_data()No breaking changes. All existing functionality is preserved. Single-node hotkeys work exactly as before. Let me know if you hate anything/everything. I know that this many lines of code increases the maintenance burden, but hopefully this adds enough features to be worth it.